Gripper Simplify #261
Merged
Gripper Simplify #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edges from the graph driver will only be able to be derived from edge tables, removing the ability to use 'fieldToField' and 'fieldToId' configurations. Those methods were never used in practic, created extensive complications in the code and configuration files, and any case where that kind of linkage would be needed, it was easier just to put the logic in the plug in and have it create an edge table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edges from the graph driver will only be able to be derived from edge tables, removing the ability to use 'fieldToField' and 'fieldToId' configurations. Those methods:
Additionally, this PR will also remove the JSON path based description of the 'toField' and 'fromField'. It was overly complicated, not user friendly, and never used. Again, any cases were a sub field needs to be used to create an edge, it is better to put the logic in the plugin, rather then try and predict every possible scenario in the engine.