Replace unmaintained ansi_term crate usage with nu_ansi_term which seems to be maintained #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! One slightly unfortunate outcome will be the need to update the minimum rust version since nu-ansi-term has a more aggressive minimum than diffy currently does. I'll try to get around to merging this, plus making some of the needed changes to get CI to pass with a newer rust version (and fix up some lints) and then i'll make another release |
…ems to be maintained Addresses https://rustsec.org/advisories/RUSTSEC-2021-0139
bmwill
force-pushed
the
replace_unmaintained_ansi_term_with_maintained_solution
branch
from
c76849b
to
e8b2ad8
Compare
|
@weiznich Just published a new release to crates.io. Due to the increase in minimum supported rust version I decided to publish a new minor version bump to 0.3.0 despite there being no other breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've choose
nu_ansi_termas alternative implementation as they seem to offer the "same" API, so it's just a matter of changing the dependency. I would appreciate a new release containing this fix to solve diesel-rs/diesel#3286Addresses https://rustsec.org/advisories/RUSTSEC-2021-0139