fix: error in BSCValidatorSet #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
changed the title
NathanBSC
previously approved these changes
Apr 8, 2023
unclezoro
reviewed
Apr 10, 2023
| @@ -418,10 +419,6 @@ contract BSCValidatorSet is IBSCValidatorSet, System, IParamSubscriber, IApplica | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
why the comments are removed?
unclezoro
approved these changes
Apr 10, 2023
NathanBSC
reviewed
Apr 10, 2023
| validatorExtraSet[i].isMaintaining = false; | ||
| validatorExtraSet[i].enterMaintenanceHeight = 0; | ||
| } else { | ||
| // if the validator is the same, update the vote address if it is different | ||
| if (!BytesLib.equal(newVoteAddrs[i], validatorExtraSet[i].voteAddress)) { |
There was a problem hiding this comment.
npm run generate-QA
fail for undeclare BytesLib
NathanBSC
approved these changes
Apr 12, 2023
unclezoro
pushed a commit
that referenced
this pull request
Apr 20, 2023
unclezoro
pushed a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix errors within
BSCValidatorSetcontractChange