Develop -> Master #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d4bae90)
…s V4] MIGRATE Update all libraries and migrate to androidx and API 28. CHANGES (to fix project after androidx update) 1) Changed naming FireBookDetails.contributors to FireBookDetails.contributorsIndexedKeys as FirebaseDatabase tries to marshall contributors data onto FireBookDetails.contributors which causes exception "expected List but found HashMap" when R8 optimizer applied. 2) Remove FixedFragmentStatePagerAdapter as androidx package is different and bug should be fixed by now. 3) Clean up dependencies.
…roidx and Glide V4. The library was is deprecated so maintenance will now be within this project.
…Event() when calling MotionEventCompat.getX(event, pointerIndex). Remove onTouchEvent() method altogether - it's not adding any useful functionality to the app currently.
…known to ZoneRulesProvider.getProvider(). E.g. "America/Punta_Arenas". Added fallback.
… Suspecting threading issue - added local variable to ensure value stays the same after null check.
…e Play Store or an internet browser installed.
…there was an error downloading books. Added null check.
…, rather use a "chooser" intent when the user wants to invite friends.
Bug fixes and migration to androidx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.