Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Paginator For OpenSearch Client #3245

Closed
1 of 2 tasks
digglife opened this issue Sep 5, 2024 · 2 comments
Closed
1 of 2 tasks

Feature: Paginator For OpenSearch Client #3245

digglife opened this issue Sep 5, 2024 · 2 comments
Assignees
Labels
feature-request This issue requests a feature. paginator

Comments

@digglife
Copy link

digglife commented Sep 5, 2024

Describe the feature

Add paginator support for OpenSearch Client.

Use Case

With this feature, we can use paginator for the OpenSearch APIs with Max Results limit, instead of looping with NextToken manually. Something like

instances = []
opensearch = boto3.client('opensearch')
paginator = opensearch.get_paginator('describe_reserved_instances')
for page in paginator.paginate():
    instances.extend(page['ReservedInstances'])

Proposed Solution

Update paginators-1.json of opensearch

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

Python SDK Botocore 1.x

Environment details (OS name and version, etc.)

macos

@digglife digglife added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2024
digglife added a commit to digglife/botocore that referenced this issue Sep 5, 2024
With this change, we can use paginator for the OpenSearch APIs with Max
Results limit, instead of looping with NextToken manually.

fixes: boto#3245
digglife added a commit to digglife/botocore that referenced this issue Sep 5, 2024
With this change, we can use paginator for the OpenSearch APIs with Max
Results limit, instead of looping with NextToken manually.

fixes: boto#3245
digglife added a commit to digglife/botocore that referenced this issue Sep 5, 2024
With this change, we can use paginator for the OpenSearch APIs with Max
Results limit, instead of looping with NextToken manually.

fixes: boto#3245
@tim-finnigan tim-finnigan self-assigned this Sep 5, 2024
@tim-finnigan tim-finnigan added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Sep 5, 2024
@tim-finnigan
Copy link
Contributor

Thanks for the feature request and for creating that PR. Paginator models are owned and maintained upstream by service teams, because they are used across AWS SDKs. Therefore the OpenSearch team would need to release these paginator models directly in order for SDKs like Boto3 to use them.

I have created an internal feature request for that service team to add the paginator models from your PR. I'm going to close this since the feature request won't be tracked here, but please refer to the CHANGELOG for future updates.

@tim-finnigan tim-finnigan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
@tim-finnigan tim-finnigan added paginator and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature. paginator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants