-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start testing on 3.13 beta build #3185
base: develop
Are you sure you want to change the base?
Conversation
It looks like all 3.13 builds are failing on these two tests due to increased memory usage with paginators:
We'll need to figure out what the delta is between 3.12 and 3.13, then see if we have an issue or there's some form of new memory leak happening in the 3.13 interpreter. Example Stacktrace
|
I had a few minutes to compare the delta values between 3.12 a 3.13. The results are shown below:
There is definitely weird something going on with the 3.13 interpreter. I don't have to time to do a deeper dive now, but wanted to add this information here for future reference. Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python 3.13.0 release candidate 3 was released on 10/01/2024 and made available in GitHub CI with actions/python-versions#308. I tested locally and this should resolved the current failures we're seeing. I requested some minor changes.
@@ -14,7 +14,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] | |||
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13-dev'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13-dev'] | |
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13'] |
@@ -68,7 +68,7 @@ def test_create_single_waiter_memory_constant(self): | |||
self.cmd('create_waiter', 's3', 'bucket_exists') | |||
self.cmd('free_waiters') | |||
self.record_memory() | |||
for _ in range(100): | |||
for _ in range(500): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for _ in range(500): | |
for _ in range(100): |
@@ -93,7 +93,7 @@ def test_create_single_paginator_memory_constant(self): | |||
self.cmd('create_paginator', 's3', 'list_objects') | |||
self.cmd('free_paginators') | |||
self.record_memory() | |||
for _ in range(100): | |||
for _ in range(500): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for _ in range(500): | |
for _ in range(100): |
This PR will start provisional testing on the recently released beta for Python 3.13. This will be used to catch any issues early before the official release in October.