Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify nearly all type errors revealed by mypy on current repo #3267

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

emeryberger
Copy link

This PR resolves nearly all of the errors produced by mypy and passes the same number of tests as before, reducing the number of type errors from 43 to 7 (6 of which are in the vendored code from six). This is laying the groundwork for a more extensive effort at annotating this code.

Before:

Found 43 errors in 13 files (checked 74 source files)

After:

Found 7 errors in 2 files (checked 74 source files)

Command line:

% mypy --install-types --non-interactive --ignore-missing-imports botocore

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.18%. Comparing base (0e229ae) to head (c727b5a).
Report is 59 commits behind head on develop.

Files with missing lines Patch % Lines
botocore/crt/auth.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3267   +/-   ##
========================================
  Coverage    93.17%   93.18%           
========================================
  Files           66       66           
  Lines        14339    14342    +3     
========================================
+ Hits         13361    13365    +4     
+ Misses         978      977    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants