Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CRC64NVME when the CRT is available. #3273

Open
wants to merge 1 commit into
base: flexible-checksums-v2
Choose a base branch
from

Conversation

jonathan343
Copy link
Contributor

@jonathan343 jonathan343 commented Oct 3, 2024

Overview

This PR adds support for the CRC64NVME checksum algorithm made available in awscrt-0.22.0. Similar to the existing CRC32C checskum algorithm, CRC64NVME will only be available when users have installed the optional CRT dependency. If CRT isn't installed and users try to this algorithm, a MissingDependencyException will be thrown.

Important

Tests are currently expected to fail until #3274 is merged. #3274 is merged and tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (flexible-checksums-v2@5a5394e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
botocore/httpchecksum.py 60.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             flexible-checksums-v2    #3273   +/-   ##
========================================================
  Coverage                         ?   93.15%           
========================================================
  Files                            ?       66           
  Lines                            ?    14347           
  Branches                         ?        0           
========================================================
  Hits                             ?    13365           
  Misses                           ?      982           
  Partials                         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants