command to swap visible files between panes per issue #13061

[core-ai-bot]

Issue by SteveMieskoski
Sunday Mar 05, 2017 at 10:04 GMT
Originally opened as adobe/brackets#13150

---

per issue #13061 , I added a function to swap visible files between panes, keybinding to Ctrl + Alt + F , and a preference with a disabled default state.
The function itself is currently located within MainViewManager.js with the command and preference manager registration located in ViewCommandhandlers.js as it seemed the logical place. There are three tests covering the basic functionality, the case where the file to move already exists in the destination pane, and where only one pane contains open/visible files. In the latter case I just call moveView.

If its felt this should not exist in the core, but in an extension I don't think that will be much of an issue. I'm interested in any Comments and/or Remarks.

---

SteveMieskoski included the following code: https://github.com/adobe/brackets/pull/13150/commits

[core-ai-bot]

Comment by zaggino
Sunday Mar 05, 2017 at 10:22 GMT

---

Looks pretty good to me, I should be able to test tomorrow.

[core-ai-bot]

Comment by zaggino
Monday Mar 06, 2017 at 00:18 GMT

---

I like the code, I like the feature, works quite well, but two things:

1. Why do I have to enable the feature in preferences?
2. This breaks Add a feature to toggle between panes in the core #10555 adobe/brackets#12853 in a way that if I use ctrl+alt+f to switch panes, alt+w stops to work until I mouse-click to the second pane, can you have a look why is that?
3. If we have alt+w to jump cursor between panes, it'd seem logical (at least to me) to have something+w to exchange them

[core-ai-bot]

Comment by SteveMieskoski
Monday Mar 06, 2017 at 23:07 GMT

---

@zaggino having it as a default disabled preference was a mention in the original issue, and wouldn't take much to implement/remove so I went in that direction. As such there isn't any necessary reason for it to be so. I'll look into why alt+w stops working, and while I'm at it also change the keybindings to something+w because I agree it makes more sense.