command to swap visible files between panes per issue #13061

[SteveMieskoski]

per issue #13061 , I added a function to swap visible files between panes, keybinding to Ctrl + Alt + F , and a preference with a disabled default state.
The function itself is currently located within MainViewManager.js with the command and preference manager registration located in ViewCommandhandlers.js as it seemed the logical place. There are three tests covering the basic functionality, the case where the file to move already exists in the destination pane, and where only one pane contains open/visible files. In the latter case I just call moveView.

If its felt this should not exist in the core, but in an extension I don't think that will be much of an issue. I'm interested in any Comments and/or Remarks.

[zaggino]

revert this change, it happens automatically after npm install but shouldn't be committed

[SteveMieskoski]

Corrected the change, and that's good to know, thanks.

[zaggino]

Looks pretty good to me, I should be able to test tomorrow.

[petetnt]

These could probably be a method like _moveView is

[SteveMieskoski]

@petetnt I looked into moving most of what is now in MainViewManager onto the pane prototype (see below), and I can push up the commit including it, however, with this setup I can't seem to get the active pane to consistently stay in place. It flips from one pane to the other every third swap. I've tried promises and a few other ideas, but Maybe I'm missing something obvious. Any insights are welcome.

    Pane.prototype.swapPaneContent = function(oppositeFile) {
        var self = this,
            oppositePane = self.id === FIRST_PANE ? SECOND_PANE : FIRST_PANE;

        if(!oppositeFile){
            var file = self.getCurrentlyViewedFile();
            MainViewManager._moveView( self.id, oppositePane.id, file , 0);
        } else {
            if (self.getViewForPath(oppositeFile.fullPath)) {
                CommandManager.execute(Commands.FILE_OPEN, {
                    fullPath: oppositeFile.fullPath,
                    paneId: self.id
                });
            } else {
                CommandManager.execute(Commands.CMD_ADD_TO_WORKINGSET_AND_OPEN, {
                    fullPath: oppositeFile.fullPath,
                    paneId: self.id
                });
            };
        };
    };

    function swapPaneContent() {

        var activePaneId = getActivePaneId(),
            inactivePaneId = activePaneId === FIRST_PANE ? SECOND_PANE : FIRST_PANE,
            activePane = _getPane(activePaneId),
            inactivePane = _getPane(inactivePaneId),
            activeFile = activePane.getCurrentlyViewedFile(),
            inactiveFile = inactivePane.getCurrentlyViewedFile();

            inactivePane.swapPaneContent(activeFile);   // addition 
            activePane.swapPaneContent(inactiveFile);  // addition
    };

[zaggino]

I don't like this rewrite ... Pane.prototype calling MainViewManager methods doesn't seem right. Maybe @petetnt can specify little more what he meant, but looking at the code I prefer the original version.

[petetnt]

Yeah, my idea was something in line with the rewrite but just calling the method with pane, file arguments instead of adding it to the prototype.

The original code is fine by me too if you think so too, you call @SteveMieskoski 👍

[zaggino]

I like the code, I like the feature, works quite well, but two things:

1. Why do I have to enable the feature in preferences?
2. This breaks Add a feature to toggle between panes in the core #10555 #12853 in a way that if I use ctrl+alt+f to switch panes, alt+w stops to work until I mouse-click to the second pane, can you have a look why is that?
3. If we have alt+w to jump cursor between panes, it'd seem logical (at least to me) to have something+w to exchange them

[SteveMieskoski]

@zaggino having it as a default disabled preference was a mention in the original issue, and wouldn't take much to implement/remove so I went in that direction. As such there isn't any necessary reason for it to be so. I'll look into why alt+w stops working, and while I'm at it also change the keybindings to something+w because I agree it makes more sense.