-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ignite, ignite-sql] clean up for apache ignite clients #1183
Comments
any chance you'd have time to work these things in the short term @isuntsov-gridgain ? I'd like to start the next release soon, but need these cleaned up first. |
Hi,
I'll take a look at this problem this evening.
сб, 14 июл. 2018 г., 8:34 Sean Busbey <notifications@github.com>:
… any chance you'd have time to work these things in the short term
@isuntsov-gridgain <https://github.com/isuntsov-gridgain> ? I'd like to
start the next release soon, but need these cleaned up first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1183 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIdh7xjRGsdVypO6VgA12UuMqJso8ZoOks5uGYL0gaJpZM4VH1zO>
.
|
awesome, thanks! |
Done #1189 |
busbey
pushed a commit
to busbey/YCSB
that referenced
this issue
Jul 27, 2018
busbey
added a commit
to busbey/YCSB
that referenced
this issue
Jul 27, 2018
…che Ignite client (addendum) * Ignite bindings should always return Status.NOT_IMPLEMENTED for scans. * rename base test class so that JUnit won't try to run the scan test without an implementation * remove unneeded additional repository definition Closes brianfrankcooper#1183
busbey
added a commit
that referenced
this issue
Jul 27, 2018
…che Ignite client (addendum) * Ignite bindings should always return Status.NOT_IMPLEMENTED for scans. * rename base test class so that JUnit won't try to run the scan test without an implementation * remove unneeded additional repository definition Closes #1183
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the merge of #1118 here are some things to take care of in the Apache Ignite (incubating) clients, preferably before the next release.
Files missing a proper license header:
Files that still have @author tags that need to be removed:
Need to confirm if copyright year is correct:
from
ignite/README.md
Can we avoid copying things into the ignite installation?
we should avoid referencing the internal classes and just use the binding names "ignite" and "ignite-sql".
from
ignite/pom.xml
I don't see any dependencies that specifically need this repository. Can we remove it?
from
ignite/src/main/java/com/yahoo/ycsb/db/ignite/IgniteClient.java
This should return
Status.NOT_IMPLEMENTED
from
ignite/src/main/java/com/yahoo/ycsb/db/ignite/IgniteSqlClient.java
This should return
Status.NOT_IMPLEMENTED
The text was updated successfully, but these errors were encountered: