Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts, core] cleanup bindings #1031

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

busbey
Copy link
Collaborator

@busbey busbey commented Sep 21, 2017

  • remove mapkeeper and voldemort from command help, since we don't build them
  • fix ordering of modules in root pom

closes #328

Copy link
Collaborator

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

* remove mapkeeper and voldemort from command help, since we don't build them
* fix ordering of modules in root pom

closes brianfrankcooper#328
@busbey
Copy link
Collaborator Author

busbey commented Sep 22, 2017

sorry, got overzealous on waiting for the build to finish. had to push an update because the azure table binding was missing from the distribution's dependencies (so it was a coincidence of pom ordering that it worked before).

Copy link
Collaborator

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

@busbey
Copy link
Collaborator Author

busbey commented Sep 22, 2017

Thanks Jason!

@busbey busbey merged commit 28b924b into brianfrankcooper:master Sep 22, 2017
@busbey busbey deleted the remove-old-bindings branch September 22, 2017 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI help lists several currently removed datastores
2 participants