Remove unnecessary getObjectMetadata() from getS3ObjectAndMetadata() #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObjectMetadata is available from S3Object.getObjectMetadata(). We don't need to send a separate GetObjectMetadata Request (an HTTP HEAD request), in order to get the metadata. This will double performance for read workloads. Signed-off-by: Xing Lin <Xing.Lin@netapp.com>
Signed-off-by: Xing Lin <xing.lin@netapp.com>
|
Thanks for the contribution! |
|
Thanks for merging the change! Glad to help. |
busbey
pushed a commit
that referenced
this pull request
May 24, 2018
…ta() (#1060) * Remove unnecessary getObjectMetadata() from getS3ObjectAndMetadata() ObjectMetadata is available from S3Object.getObjectMetadata(). We don't need to send a separate GetObjectMetadata Request (an HTTP HEAD request), in order to get the metadata. This will double performance for read workloads. Signed-off-by: Xing Lin <Xing.Lin@netapp.com> * Remove one unused import to pass style check. Signed-off-by: Xing Lin <xing.lin@netapp.com> (cherry picked from commit 381aaeb)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectMetadata is available from S3Object.getObjectMetadata().
We don't need to send a separate GetObjectMetadata Request (an
HTTP HEAD request), in order to get the metadata. With this patch,
read performance will be doubled.
Signed-off-by: Xing Lin Xing.Lin@netapp.com