[arangodb3] added ArangoDB3 binding (ArangoDB 3.1, Java driver 4.1.7) #903
Conversation
|
@mpv1989 thanks for the PR. Does this mean that this will not work with ArangoDB 2.x now? Would there be a case for trying to compare AragoDB 2.x with 3.x? |
|
@risdenk Yes, this will not work with ArangoDB 2.x anymore. I don't think a comparison between ArangoDB 2.x and 3.x is relevant. Maybe a comparison between the old Java driver and the new, both with ArangoDB 3.1.x would be interesting because the new driver offers VelocyStream/VelocyPack which results in a better performance than the old one. On the other hand, the old driver will be probably supported not for long anymore. |
|
If that is the case then maybe it makes sense to add an |
mvollmary
changed the title
|
@risdenk good idea. I reverted my changes and added an |
risdenk
changed the title
arangodb3/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| /bin/ | |||
There was a problem hiding this comment.
Is this necessary? Just curious why.
arangodb3/README.md
Outdated
| @@ -0,0 +1,93 @@ | |||
| <!-- | |||
| Copyright (c) 2012 - 2015 YCSB contributors. All rights reserved. | |||
There was a problem hiding this comment.
Since these are new files can they just be 2017? Should be the same for the other files too.
|
|
||
| ## Quick Start | ||
|
|
||
| This section describes how to run YCSB on ArangoDB. |
There was a problem hiding this comment.
Add 3.x or something in here?
arangodb3/conf/logback.xml
Outdated
|
|
||
| <configuration> | ||
|
|
||
| <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> |
There was a problem hiding this comment.
Can these messages go to STDERR instead? The convention is to have only the YCSB measurement output go to STDOUT. This makes it easier to split out when running tests.
| * permissions and limitations under the License. See accompanying | ||
| * LICENSE file. | ||
| */ | ||
| package com.yahoo.ycsb.db; |
There was a problem hiding this comment.
Can the package be com.yahoo.ycsb.db.arrangodb? This affects a few other places as well.
This change is because we are slowly moving the bindings to their own packages.
| * The database name to access. | ||
| */ | ||
| private static String databaseName = "ycsb"; | ||
| private static String collectionName = "usertable"; |
There was a problem hiding this comment.
Are databaseName and collectionName not customizable via properties?
Also can these variables be private without static? Same with the variables dropDBBeforeRun, waitforSync, and transactionUpdate
|
Thanks for the changes @mpv1989 I'll pull it down and test. |
Updated ArangoDB binding with the official Java driver in version 4.1.5 which supports ArangoDB 3.1 and above.
The driver supports ArangoDBs new binary protocol – VelocyStream – to transport VelocyPack (internal storage format of ArangoDB introduced with the 3.0 release) data between ArangoDB and client applications.