-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for HBase and Cassandra clients #98
base: master
Are you sure you want to change the base?
Conversation
I've been working on it off and on in my free time (when nothing else is on I'm close; winding out the thumbtack merge has been taking the longest.
|
Thanks for the update, @busbey! Looking forward to it. |
@busbey — where are you in your merge effort? Would it make sense to break this PR up into separate smaller PRs and bring the functionality into the repo piecemeal, rather than try to rebase the whole thing to merge it in wholesale? As you said on another thread, the style changes may make it that much harder to pull in the entire PR all at once. @jbellis — would you be able to help break this PR into smaller chunks? |
Certainly smaller PRs are much easier to work in. I've been mired in trying to back out the commit labeled "merge thumbtack" because it brings in changes the project went a different direction on. At the moment my YCSB time is focused on trying to get our documentation in a state where we can get normal PRs for it rather using than github's wiki. |
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to bring it in line with current APIs and style guide. This PR also addresses issue brianfrankcooper#326.
This fixes HBase to match the desired semantics of sending each insert or update to the server before calling it complete, instead of buffering them locally in the client until cleanup. The latter causes inaccurate latency to be reported.
Other changes are cosmetic.