Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for HBase and Cassandra clients #98

Open
wants to merge 105 commits into
base: master
Choose a base branch
from

Conversation

jbellis
Copy link

@jbellis jbellis commented Oct 24, 2012

This fixes HBase to match the desired semantics of sending each insert or update to the server before calling it complete, instead of buffering them locally in the client until cleanup. The latter causes inaccurate latency to be reported.

Other changes are cosmetic.

@mbrukman
Copy link
Contributor

mbrukman commented Oct 7, 2015

Any update on this PR? @busbey, @jbellis — are you still working on it? Or pulling out parts of it to merge piece-meal?

@busbey
Copy link
Collaborator

busbey commented Oct 7, 2015

I've been working on it off and on in my free time (when nothing else is on
fire :/ ).

I'm close; winding out the thumbtack merge has been taking the longest.
On Oct 7, 2015 5:33 PM, "Misha Brukman" notifications@github.com wrote:

Any update on this PR? @busbey https://github.com/busbey, @jbellis
https://github.com/jbellis — are you still working on it? Or pulling
out parts of it to merge piece-meal?


Reply to this email directly or view it on GitHub
#98 (comment).

@mbrukman
Copy link
Contributor

mbrukman commented Oct 7, 2015

Thanks for the update, @busbey! Looking forward to it.

@mbrukman
Copy link
Contributor

@busbey — where are you in your merge effort? Would it make sense to break this PR up into separate smaller PRs and bring the functionality into the repo piecemeal, rather than try to rebase the whole thing to merge it in wholesale? As you said on another thread, the style changes may make it that much harder to pull in the entire PR all at once.

@jbellis — would you be able to help break this PR into smaller chunks?

@busbey
Copy link
Collaborator

busbey commented Nov 25, 2015

Certainly smaller PRs are much easier to work in.

I've been mired in trying to back out the commit labeled "merge thumbtack" because it brings in changes the project went a different direction on.

At the moment my YCSB time is focused on trying to get our documentation in a state where we can get normal PRs for it rather using than github's wiki.

mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 1, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 1, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 2, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 3, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 4, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 4, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 8, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
mbrukman added a commit to mbrukman/YCSB that referenced this pull request Dec 10, 2015
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
The memcached support was extracted from PR brianfrankcooper#98 by @jbellis, with cleanups to
bring it in line with current APIs and style guide.

This PR also addresses issue brianfrankcooper#326.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants