Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to native Spotify iOS XCFramework #140

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

fotiDim
Copy link
Collaborator

@fotiDim fotiDim commented Oct 15, 2021

Spotify have silently released an XCFramework without making a new version release on GitHub. It is just checked out in their repo. I had to change the prepare-iOS-SDK.sh script to switch to this new type of framework. In fact now it is even simpler than before.

This PR brings 2 big benefits:

  • It is no more needed to manually create a module map as the XCFramework has them bundled in🎉.
  • More CPU architectures are now supported. You can use the framework on iOS simulators running on Apple Silicon (ARM64e)🍏

Caveat:

  • Git must be installed on dev's machine as it is needed to clone the repo in the script. We could document it in the ReadMe although Flutter requires Git so I don't think it is a real danger. Mac OS does come with Git preinstalled and Windows or Linux users cannot build iOS apps anyway.

brim-borium
brim-borium previously approved these changes Oct 18, 2021
Copy link
Owner

@brim-borium brim-borium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, unfortunately I don't have an iOS device at hand so can't test if the sample still works

@fotiDim fotiDim force-pushed the feature/switch-to-xcframework branch 2 times, most recently from fdb9268 to 8c22523 Compare October 18, 2021 08:16
@fotiDim
Copy link
Collaborator Author

fotiDim commented Oct 18, 2021

I rebased on main and tested again on another device. I would need you to approve once more please. No changes. Everything works on my machine™️

Bump minimum version to iOS 9 for Xcode 13
@fotiDim fotiDim force-pushed the feature/switch-to-xcframework branch from 8c22523 to bdb8043 Compare October 18, 2021 08:25
@fotiDim fotiDim merged commit b509f7d into main Nov 27, 2021
@brim-borium brim-borium deleted the feature/switch-to-xcframework branch February 22, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants