Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Fix nightly build #82

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

jaudiger
Copy link
Contributor

@jaudiger jaudiger commented Jul 8, 2024

Building on nightly is not possible due to not having the upstream ahash bug fix from tkaitchuck/aHash#183:

error[E0635]: unknown feature `stdsimd`
  --> /Users/jaudiger/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.6/src/lib.rs:99:42
   |
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |

On the current main branch, we have two ahash dependencies:

  • one on version 0.8.6
  • the other on version 0.7.7

The resolution of the bug was done in the version 0.8.7: https://github.com/tkaitchuck/aHash/releases/tag/0.8.7.

In order to build brioche on nightly, I did two things (separated in two commits):

With both changes, brioche can be built on the latest Rust nightly version 2024-07-08.

Signed-off-by: jaudiger <jeremy.audiger@ioterop.com>
Signed-off-by: jaudiger <jeremy.audiger@ioterop.com>
Copy link
Member

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylewlacy kylewlacy merged commit 1657853 into brioche-dev:main Jul 10, 2024
5 checks passed
@jaudiger jaudiger deleted the rust-nightly-build branch July 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants