Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more configuration and updated formatting #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grkvlt
Copy link
Member

@grkvlt grkvlt commented Sep 10, 2016

  • Only changes entities in same application
  • Uses AttributeSensor config type for coercion
  • Standardisd YAML formatting on all files
  • Configure entity filter and optional host file overwrite

Copy link
Member

@ahgittin ahgittin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. I'd rather a brooklyn "scope" (this app v all apps) field in Group rather than adding the predicate but it can be changed later (with default being all apps now, but deprecated and warning so we can change it later). I'd also like to have the QA framework running against this so we have confidence it works.

But if you've tested I'm happy to have this merged.

@grkvlt
Copy link
Member Author

grkvlt commented Sep 15, 2016

@ahgittin still needs a bit of testing, so not yet ready to merge

- Only changes entities in same application
- Uses AttributeSensor config type for coercion
- Standardisd YAML formatting on all files
- Configure entity filter and optional host file overwrite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants