Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API parity tables #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add API parity tables #35

wants to merge 3 commits into from

Conversation

goto-bus-stop
Copy link
Member

Since the Node.js version implemented by this module differs for each API, a table might be helpful to inform users what APIs they can use (and to keep track of what is still to be done).

@BridgeAR
Copy link
Member

BridgeAR commented May 6, 2019

Seems like a good idea until everything is up to date but even then it's good to know the feature parity.

|-|-|
| `callbackify` | 12.1.0 |
| `debuglog` | 0.11.3 |
| `format` | <8.4.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning the exact version that is reflected seems better than having this notation. There might be more patch releases that could change some small things from the last time this was checked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

Since the Node.js version implemented by this module differs for each API, a table might be helpful to inform users what APIs they can use (and to keep track of what is still to be done).
strictly this commit is missing:
nodejs/node@1b9c40c

inconsequential really, but we shouldn't lie!
@goto-bus-stop
Copy link
Member Author

(I will confirm the inspect and format versions later, may need to compare source a bit)

| `getSystemErrorName` | missing |
| `inherits` | 12.1.0 |
| `inspect` | <6.0.0 |
| `isDeepStrictEqual` | missing |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://npmjs.com/deep-equal, with { strict: true }?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants