Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 269] Print the build number on the console output after triggering the image build #344

Conversation

Priyanka-Kotturi
Copy link
Contributor

This pull request resolves Issue #269, printing the build number on the console output when we trigger the image build using the kp trigger command

@Priyanka-Kotturi Priyanka-Kotturi requested a review from a team as a code owner August 21, 2023 08:57
Co-authored-by: Sasi Kumar
@Priyanka-Kotturi Priyanka-Kotturi changed the title Issue 269 Print the build number on the console output after triggering the image build [Issue 269] Print the build number on the console output after triggering the image build Aug 23, 2023
Copy link
Contributor

@chenbh chenbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a small change to avoid hard coding the annotation key

pkg/commands/image/trigger.go Outdated Show resolved Hide resolved
pkg/commands/image/trigger.go Outdated Show resolved Hide resolved
@Priyanka-Kotturi Priyanka-Kotturi force-pushed the Issue-269-add-buildid-for-kp-trigger branch 2 times, most recently from edcca72 to c59e941 Compare August 25, 2023 09:55
@Priyanka-Kotturi
Copy link
Contributor Author

Thanks @chenbh for the suggestion, used the constant for the annotation key.

Copy link
Contributor

@chenbh chenbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenbh chenbh merged commit 56623c5 into buildpacks-community:main Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants