Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Terraform v1.0.0, use Dependabot #231

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Update to Terraform v1.0.0, use Dependabot #231

merged 2 commits into from
Jun 16, 2021

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Jun 15, 2021

Closes: #226
Refs: #228

@github-actions
Copy link

github-actions bot commented Jun 15, 2021

Terraform Plan:

will create 1 resource:

  • local_file - appspec_json

will update 7 resources:

  • aws_s3_bucket - my_s3_bucket_logs
  • aws_alb - alb
  • aws_ecs_service - service
  • aws_iam_role - task_execution_role
  • aws_iam_role - task_role
  • aws_iam_role - test_lambda
  • aws_lambda_function - test_lambda

will replace (delete then create) 1 resource:

  • aws_ecs_task_definition - task_def

see details

Comment on lines +25 to +35
# - package-ecosystem: terraform
# directory: '/terraform-iac/dev/app'
# schedule:
# interval: daily
# target-branch: dev

# - package-ecosystem: terraform
# directory: '/terraform-iac/dev/setup'
# schedule:
# interval: daily
# target-branch: dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the idea of getting 8 PRs whenever we need to update the AWS provider, but I can't think of a way around that until dependabot/dependabot-core#2178 is added.

@GaryGSC
Copy link
Member Author

GaryGSC commented Jun 15, 2021

Are we thinking that the Dependabot stuff is blocked on #212?

@GaryGSC
Copy link
Member Author

GaryGSC commented Jun 15, 2021

It looks like the main difference to the TF plan is the way we now mark more things as sensitive.

@GaryGSC GaryGSC requested a review from a team June 15, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants