Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix int formatting in std::collections::object #1521

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

Renerick
Copy link
Contributor

@Renerick Renerick commented Oct 5, 2024

Reported at https://discord.com/channels/650345951868747808/650347464498610189/1291898838772088832

When the value is a signed integer, it's still formatted as unsigned integer:

io::printn(b_value.type.kindof);
io::printn(b_value);
io::printn((int128)b_value.i);
SIGNED_INT
340282366920938463463374607431768211414
-42

@lerno
Copy link
Collaborator

lerno commented Oct 5, 2024

Ideally there is also a note in the releasenotes for this, but I'm going to accept this as is. But something to think about in the future.

@lerno lerno merged commit 217151b into c3lang:master Oct 5, 2024
42 checks passed
@lerno
Copy link
Collaborator

lerno commented Oct 5, 2024

Thank you!

@Renerick Renerick deleted the fix-object-to_format branch October 5, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants