-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry] add ability to contextualize span name #5171
Comments
Sounds like we just need placeholder support for the span name. Is it possible to run the replacer at runtime, or must the span name be known at provision-time? FYI @cdaguerre the syntax would be more like this:
Where For response header values, that's trickier because AFAIK the trace is set up at the start of the request, before handling, not after, on the way out. Definitely possible to wire up with a request header though, I think. But I might be wrong here. |
Thanks for clarifying the syntax! I don't know the first thing about Go but this looks "provision-time". For most frameworks operation naming in line with OpenTelemetry's semantic conventions can not be achieved through mere request manipulation and is probably much easier to handle at framework level then with request info manipulation on caddy level, hence the suggestion, although I'm not sure it's very clean ;) |
Any news on the implementation of this feature? Sounds quite interesting. |
The Caddy maintainers don't use tracing or metrics ourselves, so we have very little incentive to spend time working on it. So we're asking for the community to help maintain those parts. |
Understandable. |
Since caddy is often the entry point to an application, it's generally the root span and it's name becomes the operation name of the entire trace. As a result, tools like Jaeger show a list of various operations that all have the same name.
It would be great if the span name could be customized on a "per request" basis with string interpolation in the span name, eg.
or even get the operation name from the upstream like this:
The text was updated successfully, but these errors were encountered: