core: Windows service integration #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Interesting, will take a look at this. Thanks! |
mholt
requested changes
Jun 10, 2022
There was a problem hiding this comment.
Sorry this took me so long to get to. This actually looks really good. But do you think we could move service_windows.go into notify_windows.go? Maybe I'm missing something but since it runs from init(), it doesn't seem super relevant to have it in a separate package and file.
|
@WingLim Are you still interested in finishing this PR? |
We haven't supported Go 1.16- for a long time now, so remove old-style `// +build` tags. Also remove unnecessary pragmas that are already specified in filenames.
|
@WingLim Oh, I see the difficulty of moving the files like I asked. I just went ahead and cleaned up the build tags/pragmas instead and I think we'll merge this. Thanks! |
mholt
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a
svc.Handlerand run it ininitfunction, so that caddy can usesc.exeto manage a windows service.With this PR, we can add service like this:
TODO:
Resolve #4670