Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin: use replacer on listen address #5071

Merged
merged 2 commits into from
Sep 29, 2022
Merged

admin: use replacer on listen address #5071

merged 2 commits into from
Sep 29, 2022

Conversation

yroc92
Copy link
Collaborator

@yroc92 yroc92 commented Sep 23, 2022 •
edited
Loading

This allows you to use environment variables and other placeholders in your admin.listen and admin.remote.listen addresses.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mholt
mholt reviewed Sep 24, 2022
View reviewed changes
admin.go Outdated Show resolved Hide resolved
mholt
mholt approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Cory!

@mholt mholt merged commit 037dc23 into master Sep 29, 2022
@mholt mholt deleted the admin-listen-replace branch September 29, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yroc92 @CLAassistant @mholt