httpcaddyfile: Ignore the import empty dotfile.

[u5surf]

• Fixes [feature request] ignore dotfiles by default when parsing drop-in configuration #5295
  ignore the empty dot file while it imports.
  and also warning in this situation.

#5295 (comment)

[francislavoie]

I don't think this is quite right.

I think we want to:

• Always ignore dot files by default with a glob, when the last path segment of the glob is *, i.e. still import dotfiles with import /subdir/.*
• Change empty files from an error to a warning

Those are two separate changes, not related.

[francislavoie]

This still isn't right. I think you misunderstood the requirements. How did you try testing this? I think this will need some tests to show that it works correctly.

• import path/to/empty_file.txt currently returns an EOF error. It should now instead just log a warning, and result in no tokens.
• import path/to/dir/* currently tries to import dotfiles as well with the * glob. It should instead skip any files that start with a . when iterating over them.
• import path/to/dir/.* currently reads all dotfiles in a dir. It should continue to do so. The idea is that this is an escape hatch to still load all dotfiles as config if the user wants to, when pairing with import path/to/dir/* which does not import the dotfiles.

[mholt]

I want to emphasize, though, we are very grateful for the patch 💯 😃 We probably could have better clarified the requirements in the issue and will try to do so in the future!

[francislavoie]

Thanks! This is looking a lot better.

[mholt]

Awesome, thanks so much! Let's give this a whirl :)