Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddyfile: Allow overriding server names #5323

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Conversation

francislavoie
Copy link
Member

Fix #5322

Copy link
Member

@emilylange emilylange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks when two different servers are called the same:

{
	servers :443 {
		name https
	}

	servers :8000 {
		name https
	}
}

example.com {
}

:8000 {
}
{
    "apps": {
        "http": {
            "servers": {
                "https": {
                    "listen": [
                        ":8000"
                    ]
                }
            }
        }
    }
}

@francislavoie
Copy link
Member Author

Ah right, I should reject duplicate names.

@francislavoie francislavoie force-pushed the caddyfile-server-names branch 2 times, most recently from 947340a to 05df69d Compare January 21, 2023 17:59
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is something I hoped we wouldn't really have to care about... but here we are. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support changing the internal server name/id via Caddyfile
3 participants