-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caddyfile: Allow overriding server names #5323
Conversation
5fdb9df
to
145856d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks when two different servers are called the same:
{
servers :443 {
name https
}
servers :8000 {
name https
}
}
example.com {
}
:8000 {
}
{
"apps": {
"http": {
"servers": {
"https": {
"listen": [
":8000"
]
}
}
}
}
}
Ah right, I should reject duplicate names. |
95ae684
to
e86a9ca
Compare
947340a
to
05df69d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is something I hoped we wouldn't really have to care about... but here we are. 😅
05df69d
to
3c82a10
Compare
Fix #5322