Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump tscert package to fix Tailscale 1.34+ on Windows #5331

Conversation

bradfitz
Copy link
Contributor

As of Tailscale 1.34.0 on Windows, Tailscale now uses a named pipe to connect to the local tailscale service.

This pulls in tailscale/tscert#5 as reported in tailscale/tscert#4.

(Sorry, we should've noticed this earlier!)

As of Tailscale 1.34.0 on Windows, Tailscale now uses a named pipe to
connect to the local tailscale service.

This pulls in tailscale/tscert#5 as reported in tailscale/tscert#4.

(Sorry, we should've noticed this earlier!)

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2023

CLA assistant check
All committers have signed the CLA.

@bradfitz
Copy link
Contributor Author

cc @mholt

Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@francislavoie
Copy link
Member

As an aside FYI, we've had some users in the Caddy forums ask for a solution to proxying multiple services from the same machine with Caddy + TS, but tailscale/tailscale#3847 (comment) has been a blocker for that. We typically recommend users serve each service with a subdomain, because many apps don't handle being served in a subpath too well. Just wanted to put that on your radar as something that's come up recently.

@francislavoie francislavoie merged commit 98867ac into caddyserver:master Jan 25, 2023
@mholt
Copy link
Member

mholt commented Jan 25, 2023

Hey Brad, thanks! I'm returning to the office tomorrow so I'll check this closer right away then.

@francislavoie francislavoie added the bug 🐞 Something isn't working label Jan 25, 2023
@francislavoie francislavoie added this to the v2.6.3 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants