caddyfile: Fix heredoc fuzz crasher, drop trailing newline #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was mixing string and []rune and that broke on multi-byte runes and such. Whoops. Co-authored-by: Mohammed Al Sahaf <msaa1990@gmail.com>
|
While looking at this, I realized that we were keeping a trailing newline in the heredoc output. That's not a good idea, because it forces the user to always have a newline in the output. If we remove the trailing newline, then the user can just add another newline of their own to include one, if they want it. |
francislavoie
changed the title
mohammed90
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was mixing string and []rune and that broke on multi-byte runes and such. Whoops.
Followup to #5385, Closes #5400