Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing slash on fs filenames #5417

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

esell
Copy link
Contributor

@esell esell commented Mar 3, 2023

Minor change to fix #5416

Tested with osFS and caddy-fs-s3, and confirmed that path canonicalization redirects still happen successfully.

@mholt mholt enabled auto-merge (squash) March 3, 2023 21:29
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thanks for the patch and the testing!

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

@mholt mholt merged commit 94d41a9 into caddyserver:master Mar 3, 2023
@francislavoie
Copy link
Member

Did you test that browse still works correctly? There's a bunch of other code following that line that uses the same variable, and I'm worried any of those other places could have unexpected breakages.

@esell
Copy link
Contributor Author

esell commented Mar 3, 2023

The browse scenario was my specific use-case. You can check it out here: https://zines.esheavyindustries.com/ I am using a locally built version of Caddy with this code change to serve it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Caddy be adding /'s to fs.FS paths?
4 participants