feat: better implementation of grid layout #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! I could never quite wrap my head around grid. Looking forward to using this. |
mholt
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current "browse" listings grid layout is encountering a display problem where the last line of displayed files tends to occupy the entire line, leading to incorrect alignment. I have attempted to address this issue using grid layout, the effects of which can be seen in the record 2. Each file is now better aligned and displays more appropriately across various screen aspect ratios.Thank you for your consideration.
Current (With flex layout)
Record 1:
https://github.com/caddyserver/caddy/assets/74791570/4744ba80-dcbf-4a42-9ec1-5f992b8c58c6
Updated (With grid layout)
Record 2:
Enregistrement.d.ecran.le.2023-06-04.a.17.58.20.mov