Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: MkdirAll appDataDir in InstanceID with 0o700 #6340

Merged
merged 2 commits into from
May 30, 2024

Conversation

akovalenko
Copy link
Contributor

appDataDir components should be searchable (u+x) when they are created, or else Caddy is unable to start with an empty HOME.

appDataDir components should be searchable (u+x) when they are
created, or else Caddy is unable to start with an empty HOME.
@akovalenko
Copy link
Contributor Author

Fixes #6341

@mholt
Copy link
Member

mholt commented May 29, 2024

Thank you for the contribution! I'm still having trouble reproducing the original issue but as soon as we figure that out I'll merge this. (I actually feel this is right but I want to understand why I don't have the problem.)

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm still not able to reproduce this nor do I really understand who this affects, it's clearer to me now that this is more correct. Thanks for the patch.

@mholt mholt merged commit a52917a into caddyserver:master May 30, 2024
23 checks passed
@mholt mholt added this to the v2.8.1 milestone May 30, 2024
@manselmi
Copy link

manselmi commented May 30, 2024

@akovalenko Thank you for this PR! I was also affected by this and thought I was losing it…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants