Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build and test with Go 1.23 #6526

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

dunglas
Copy link
Collaborator

@dunglas dunglas commented Aug 18, 2024

Adds Go 1.23 to the CI/CD pipeline.
Removes support for Go 1.21, which isn't maintained anymore.
Bumps golangci-lint to v1.60 (needed for Go 1.23) and fixes newly discovered errors.

Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@dunglas
Copy link
Collaborator Author

dunglas commented Aug 19, 2024

@mholt you'll have to remove the required checks for Go 1.21 (which has been removed) in the GitHub settings to merge this. You should also add new requirements for Go 1.23.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! Done and done.

@mholt mholt merged commit 2028da4 into caddyserver:master Aug 23, 2024
33 checks passed
@mholt mholt added the CI/CD 🔩 Automated tests, releases label Aug 23, 2024
@dunglas dunglas deleted the chore/go-1.23 branch August 23, 2024 17:04
@mholt mholt added the go Pull requests that update Go code label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants