Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for Pebble Notices #1086

Merged
merged 18 commits into from
Dec 15, 2023
Merged

feat: support for Pebble Notices #1086

merged 18 commits into from
Dec 15, 2023

Commits on Dec 7, 2023

  1. Initial work on Pebble Notices integration

    @benhoyt
    benhoyt committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    e34770b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pebble-notices 

    Resolved conflicts:

- ops/model.py
- test/test_model.py
    @benhoyt
    benhoyt committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0e18076 View commit details
    Browse the repository at this point in the history

  3. Fix unit tests

    @benhoyt
    benhoyt committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3856a2c View commit details
    Browse the repository at this point in the history

  4. Add tests for parse_duration

    @benhoyt
    benhoyt committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    5001316 View commit details
    Browse the repository at this point in the history

  5. More specific parse_duration error in invalid float case

    @benhoyt
    benhoyt committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    9046b5d View commit details
    Browse the repository at this point in the history

  6. Add Notice and get_notices tests

    @benhoyt
    benhoyt committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a1eb569 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Add model tests for Container.get_notice(s) and LazyNotice

    @benhoyt
    benhoyt committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    8df9c82 View commit details
    Browse the repository at this point in the history

  2. Fix PebbleNoticeEvent's snapshot and restore; add tests

    @benhoyt
    benhoyt committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a5e85d0 View commit details
    Browse the repository at this point in the history

  3. Add main.py tests of PebbleCustomNotice event

    @benhoyt
    benhoyt committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    328b156 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'main' into pebble-notices

    @benhoyt
    benhoyt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    dd18c21 View commit details
    Browse the repository at this point in the history

  2. Update to latest spec: single user_id and select filters

    @benhoyt
    benhoyt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9a32f8a View commit details
    Browse the repository at this point in the history

  3. Remove pebble_notify for now (will do Harness support in later PR)

    @benhoyt
    benhoyt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    5a5e038 View commit details
    Browse the repository at this point in the history

  4. Add _NoticeDict ignore to make "tox -e docs" succeed

    @benhoyt
    benhoyt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f6add08 View commit details
    Browse the repository at this point in the history

  5. Tweak NoticesSelect docstring

    @benhoyt
    benhoyt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    acd092a View commit details
    Browse the repository at this point in the history

  6. Add user_id param to get_notices docstring

    @benhoyt
    benhoyt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e1db0ea View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Code review changes from Tony's review 

    Also remove LazyNotice.notice property
    @benhoyt
    benhoyt committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f260e29 View commit details
    Browse the repository at this point in the history

  2. Add note to CHANGES.md about the new feature

    @benhoyt
    benhoyt committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c0b01ef View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Change approach to duration parsing to (try to) preserve precision 

    This seems very unlikely to matter in practice, but I like the
algorithm more this way in any case.
    @benhoyt
    benhoyt committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    40357ef View commit details
    Browse the repository at this point in the history