Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [1553] Add disableCrossOriginPolicy setting to disable cors in the browser #1554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/happy-dom/src/browser/types/IBrowserSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ export default interface IBrowserSettings {
/** Disables CSS file loading. */
disableCSSFileLoading: boolean;

/** Disables cross-origin policy. */
disableCrossOriginPolicy: boolean;

/** Disables computed style rendering. */
disableComputedStyleRendering: boolean;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ export default interface IOptionalBrowserSettings {
/** Disables JavaScript evaluation. */
disableJavaScriptEvaluation?: boolean;

/** Disables Cross Origin Policy for http requests. */
disableCrossOriginPolicy?: boolean;

/** Disables JavaScript file loading. */
disableJavaScriptFileLoading?: boolean;

Expand Down
5 changes: 4 additions & 1 deletion packages/happy-dom/src/fetch/Fetch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ export default class Fetch {
}
this.redirectCount = options.redirectCount ?? 0;
this.disableCache = options.disableCache ?? false;
this.disableCrossOriginPolicy = options.disableCrossOriginPolicy ?? false;
this.disableCrossOriginPolicy =
options.disableCrossOriginPolicy ??
this.#browserFrame.page.context.browser.settings.disableCrossOriginPolicy ??
false;
}

/**
Expand Down
5 changes: 4 additions & 1 deletion packages/happy-dom/src/fetch/SyncFetch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ export default class SyncFetch {
}
this.redirectCount = options.redirectCount ?? 0;
this.disableCache = options.disableCache ?? false;
this.disableCrossOriginPolicy = options.disableCrossOriginPolicy ?? false;
this.disableCrossOriginPolicy =
options.disableCrossOriginPolicy ??
this.#browserFrame.page.context.browser.settings.disableCrossOriginPolicy ??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super useful

false;
}

/**
Expand Down
Loading