Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0028 | update with Babbage protocol parameters #337

Closed
wants to merge 2 commits into from
Closed

CIP-0028 | update with Babbage protocol parameters #337

wants to merge 2 commits into from

Conversation

kevinhammond
Copy link
Contributor

No description provided.

@kevinhammond
Copy link
Contributor Author

kevinhammond commented Sep 26, 2022

This CIP reflects the changes to protocol parameters in Babbage to define a Plutus V2 cost model

@kevinhammond kevinhammond changed the title changed to reflect babbage Changed CIP-0028 (Protocol Parameters) to reflect Babbage changes Sep 26, 2022
@rphair rphair changed the title Changed CIP-0028 (Protocol Parameters) to reflect Babbage changes CIP-0028 | update with Babbage protocol parameters Sep 30, 2022
@rphair rphair added the Update Adds content or significantly reworks an existing proposal label Sep 30, 2022
@KtorZ
Copy link
Member

KtorZ commented Oct 6, 2022

This isn't the only change as far as I recall. There is also:

  • coinsPerUTxOByte replacing lovelacePerUTxOWord
  • removal of extraEntropy
  • removal of decentralizationParameter

(and I think that's all).

In addition, we have created separate document by the past to cover protocol parameters (as CIP-0009 (Shelley) and CIP-0028 (Alonzo)), and, @JaredCorduan did create an extension a while back for Babbage as CIP-0055 (Babbage) only covering the coinsPerUTxOByte change however. already covering those changes.

So I'd suggest to make this addition in CIP-0055 instead , and also mention the removal of the two params (extraEntropy + decentralizationParameter) compared to Alonzo with a line of rationale for each.

@JaredCorduan
Copy link
Contributor

@KtorZ @kevinhammond - CIP-0055 already covers coinsPerUTxOByte and the removal of those two protocol parameters (d and extraEntropy.

@KtorZ
Copy link
Member

KtorZ commented Oct 6, 2022

@JaredCorduan whoops indeed, I forgot that the removal of d and extraEntropy was added to CIP-0055 in the end. So I guess, if we want to add a mention to the new cost model in there (CIP-0055), that's fine but that's a bit out of topic for CIP-0028.

Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to CIP-0055, not CIP-0028

@rphair
Copy link
Collaborator

rphair commented Oct 25, 2022

@kevinhammond what @KtorZ says above looks right: the later numbered CIP (@JaredCorduan #265) has a very small list of changed parameters, which would be incomplete without this added list... as likewise this longer list is likely to get overlooked if it stands on its own. Can you refactor your additions into https://github.com/cardano-foundation/CIPs/tree/master/CIP-0055 instead - or do you have any objection?

@kevinhammond
Copy link
Contributor Author

kevinhammond commented Nov 15, 2022

I think it's better to merge CIP-0055 into this one. It's not really standalone as far as I can see and we don't want to proliferate the parameter CIPs. It's better to have fewer CIP numbers to refer to when checking parameter settings and changes.

@kevinhammond
Copy link
Contributor Author

I have merged in CIP-55 @JaredCorduan and @KtorZ

@KtorZ
Copy link
Member

KtorZ commented Nov 15, 2022

@kevinhammond , for the sake of clarity, as stated earlier, we want the opposite; this addition to be merged into CIP-0055 and not the other way around. It's best to have one proposal per era since we started doing this. There's one for Shelley, one for Alonzo and CIP-0055 is the one partially covering Babbage.

@kevinhammond
Copy link
Contributor Author

kevinhammond commented Nov 15, 2022

Unlike Alonzo, Babbage doesn't really have its own set of parameters, @KtorZ. We're also about to make another tiny change with PV8

@KtorZ
Copy link
Member

KtorZ commented Nov 15, 2022

What do you mean? It surely does! While there's no new genesis configuration for Babbage, it still defines some new parameters and removes some existing ones. The goal of CIP-0055 was to highlight those changes. For PV8, I'd suggest to re-use a similar approach to what was done before with a Changelog in the Path to Active section (e.g. https://github.com/cardano-foundation/CIPs/tree/master/CIP-0009#change-log)

@KtorZ KtorZ added Category: Ledger Proposals belonging to the 'Ledger' category. State: Waiting for Author Proposal showing lack of documented progress by authors. labels Mar 18, 2023
@kevinhammond kevinhammond closed this by deleting the head repository Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Ledger Proposals belonging to the 'Ledger' category. State: Waiting for Author Proposal showing lack of documented progress by authors. Update Adds content or significantly reworks an existing proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants