-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0028 | update with Babbage protocol parameters #337
CIP-0028 | update with Babbage protocol parameters #337
Conversation
This CIP reflects the changes to protocol parameters in Babbage to define a Plutus V2 cost model |
This isn't the only change as far as I recall. There is also:
(and I think that's all). In addition, we have created separate document by the past to cover protocol parameters (as CIP-0009 (Shelley) and CIP-0028 (Alonzo)), and, @JaredCorduan did create an extension a while back for Babbage as CIP-0055 (Babbage) So I'd suggest to make this addition in CIP-0055 instead |
@KtorZ @kevinhammond - CIP-0055 already covers |
@JaredCorduan whoops indeed, I forgot that the removal of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added to CIP-0055, not CIP-0028
@kevinhammond what @KtorZ says above looks right: the later numbered CIP (@JaredCorduan #265) has a very small list of changed parameters, which would be incomplete without this added list... as likewise this longer list is likely to get overlooked if it stands on its own. Can you refactor your additions into https://github.com/cardano-foundation/CIPs/tree/master/CIP-0055 instead - or do you have any objection? |
I think it's better to merge CIP-0055 into this one. It's not really standalone as far as I can see and we don't want to proliferate the parameter CIPs. It's better to have fewer CIP numbers to refer to when checking parameter settings and changes. |
I have merged in CIP-55 @JaredCorduan and @KtorZ |
@kevinhammond , for the sake of clarity, as stated earlier, we want the opposite; this addition to be merged into CIP-0055 and not the other way around. It's best to have one proposal per era since we started doing this. There's one for Shelley, one for Alonzo and CIP-0055 is the one partially covering Babbage. |
Unlike Alonzo, Babbage doesn't really have its own set of parameters, @KtorZ. We're also about to make another tiny change with PV8 |
What do you mean? It surely does! While there's no new genesis configuration for Babbage, it still defines some new parameters and removes some existing ones. The goal of CIP-0055 was to highlight those changes. For PV8, I'd suggest to re-use a similar approach to what was done before with a Changelog in the |
No description provided.