Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0124? | Extend token metadata for translations #488

Merged
merged 46 commits into from
Sep 3, 2024

Conversation

granada-pool
Copy link
Contributor

@granada-pool granada-pool commented Mar 24, 2023

This proposal defines an additional property to the NFT and FT metadata standard to support text localization.


(rendered proposal in branch)

Add a property for string localization to prepare NFTs and metaverse solutions for mass adoption.
Added first draft of CIP proposal with implementation examples.
Added strings localization support for collections and for multi-asset policies.
Changed TypeScript implementation.
Added Github repos and relevant links for proposal authors.
Reverted last changes as it breaks YAML syntax
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your project folder from CIP-1856 to something else beginning with CIP- but not a number (derived from your proposal name, or ????). This is relatively important for 1856 because we had a potential CIP-1856 for a while: #104

CIP-1856/README.md Outdated Show resolved Hide resolved
CIP-1856/README.md Outdated Show resolved Hide resolved
CIP-1856/README.md Outdated Show resolved Hide resolved
CIP-1856/README.md Outdated Show resolved Hide resolved
CIP-1856/README.md Outdated Show resolved Hide resolved
CIP-1856/README.md Outdated Show resolved Hide resolved
CIP-1856/README.md Outdated Show resolved Hide resolved
CIP-1856/README.md Outdated Show resolved Hide resolved
@rphair rphair changed the title CIP1856 | Extend metadata standard (translations) CIP-???? | Extend metadata standard for translations Mar 24, 2023
@rphair rphair added the Category: Metadata Proposals belonging to the 'Metadata' category. label Mar 24, 2023
@rphair rphair changed the title CIP-???? | Extend metadata standard for translations CIP-???? | Extend token metadata for translations Mar 24, 2023
granada-pool and others added 10 commits March 25, 2023 13:44
Adjustment CIP ID from pull request review.

Co-authored-by: Robert Phair <rphair@cosd.com>
Changed Status to "Proposed"

Co-authored-by: Robert Phair <rphair@cosd.com>
Simplified title according to pull request review.

Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Improved wording on Abstract and Motivation.
Fixed YAML
CIP-1856/README.md Outdated Show resolved Hide resolved
Added Implementation plan and updated standard extension proposal with alternative to reduce the size of the metadata.
@rphair
Copy link
Collaborator

rphair commented Apr 13, 2023

Thanks @granada-pool for the latest updates & including the peer review from NMKR. Can you please rename the project folder from CIP-1856 to something without a number it it (e.g. CIP-????, CIP-XXXX, CIP-token-metadata-translations)?

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Padierfind if you could please assist here:

  • This proposal seems good enough for me to approve (mainly based on web standards experience; I'm not a token metadata expert) if we could have a peer review, or even just an acknowledgement, of this PR coming from the NMKR direction.
  • If there are any revisions to how your peer review is presented in the CIP please suggest alternative language and/or discuss it in this PR.

CIP-token-metadata-translations/README.md Outdated Show resolved Hide resolved
@rphair rphair changed the title CIP-???? | Extend token metadata for translations CIP-0124? | Extend token metadata for translations Jun 11, 2024
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@granada-pool this was generally seen at tonight's CIP meeting to be ready to progress to the final Last Check stage before merge as soon as @Ryun1's feedback above is addressed. (The CDDL spec is a rather big thing that it needs first.)

Please also change the containing directory name to CIP-0124 🎉

CIP-token-metadata-translations/README.md Outdated Show resolved Hide resolved
@rphair
Copy link
Collaborator

rphair commented Aug 20, 2024

@granada-pool are you still advocating this? Based on no response to the 2 reviews above it appears abandoned & so we're tagging at such (it's not really Waiting for Author since the proposal specification was well received in review except for some document particulars, as recorded above).

It would seem a shame to close this PR after you have basically done all the work, so please respond to the feedback above if & when you can. (Proposals marked as apparently "Abandoned" will be closed some time afterward if no further progress is made.)

@rphair rphair added the State: Waiting for Author Proposal showing lack of documented progress by authors. label Aug 20, 2024
granada-pool and others added 5 commits August 20, 2024 13:49
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
…dded CDDL files with the extended standard based on CIP-25.
@granada-pool
Copy link
Contributor Author

@granada-pool this was generally seen at tonight's CIP meeting to be ready to progress to the final Last Check stage before merge as soon as @Ryun1's feedback above is addressed. (The CDDL spec is a rather big thing that it needs first.)

Please also change the containing directory name to CIP-0124 🎉

@rphair Great to know! I just made some changes based on your comments and suggestions

@granada-pool
Copy link
Contributor Author

@granada-pool are you still advocating this? Based on no response to the 2 reviews above it appears abandoned & so we're tagging at such (it's not really Waiting for Author since the proposal specification was well received in review except for some document particulars, as recorded above).

It would seem a shame to close this PR after you have basically done all the work, so please respond to the feedback above if & when you can. (Proposals marked as apparently "Abandoned" will be closed some time afterward if no further progress is made.)

@rphair Absolutely! I apologize for the delay, I had quite a lot on my plate with the development of VAULT3 and the RareEvo event. Hope the changes made today satisfy all reviews. Please tag me if there are more improvements to make.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @granada-pool - just one last pass for me before we try to push this through:

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(accidentally hit "Submit" button above)

CIP-0124/README.md Outdated Show resolved Hide resolved
CIP-0124/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@granada-pool I think we are all in order now although I will leave it to @Ryun1 @Crypto2099 to confirm the CDDL spec + recent updates. Marking as Last Check since I think this is now good to finally merge as soon as we have their confirmation.

@rphair rphair added State: Last Check Review favourable with disputes resolved; staged for merging. and removed State: Waiting for Author Proposal showing lack of documented progress by authors. labels Sep 3, 2024
CIP-0124/README.md Outdated Show resolved Hide resolved
@rphair rphair merged commit 5501771 into cardano-foundation:master Sep 3, 2024
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Metadata Proposals belonging to the 'Metadata' category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants