Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top-level README: meeting #73 promotion #595

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Sep 19, 2023

apologies for making a separate PR for this: I was going to sneak it in before merging #509 but thought we had other name changes to make as per #594 (these were only PRs & not CIP candidates). 😖

@rphair rphair added the Bi-Weekly Notes / Editorial Housekeeping Publishing Bi-weekly meetings minutes / Mintor edits of public surrounding information label Sep 19, 2023
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rphair rphair requested a review from Ryun1 September 21, 2023 00:16
@Crypto2099
Copy link
Collaborator

Didn't we settle on the vertical pipe ( | ) character for the delineator rather than the dash? This seems to have reverted to the dash separator format which IMO may be ambiguous and cause confusion if proper spacing is not maintained.

@Ryun1
Copy link
Collaborator

Ryun1 commented Sep 21, 2023

@Crypto2099 the pipe unfortunately broke how markdown tables are rendered on Github

@rphair
Copy link
Collaborator Author

rphair commented Sep 21, 2023

@Crypto2099: Didn't we settle on the vertical pipe ( | ) character for the delineator rather than the dash?

yes, I still feel this would have been functionally & typographically ideal, but we'd all regret it as various artefacts and incompatibilities of <code>&#124;</code> started appearing everywhere in repurposed lists of CIPs 😖 #595 (comment)

@rphair rphair merged commit 6153866 into cardano-foundation:master Sep 21, 2023
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
…dano-foundation#595)

* merged CIP-0095 and corrected its name

* wallet API delimiter changed to - as per updated cardano-foundation#594

* already merged CIP-0095 also needs delimiter change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bi-Weekly Notes / Editorial Housekeeping Publishing Bi-weekly meetings minutes / Mintor edits of public surrounding information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants