Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-1694 | French - Clarify note on info actions #846

Closed
wants to merge 1 commit into from
Closed

CIP-1694 | French - Clarify note on info actions #846

wants to merge 1 commit into from
+235 −235

Conversation

Hornan7
Copy link
Contributor

@Hornan7 Hornan7 commented Jun 25, 2024

  • Correction to the french version related to PR CIP-1694 | Reword note on info actions #834
  • Complete audit of the French version
  • Modification and preservation of terms that are machine readable. ex: Yes, No, Abstain
  • Correction of erroneous and confusing term such as "mesure de gouvernance" and "mise"
  • Fixed several turns of phrase in a better French.

@Hornan7
CIP-1694 | French - Clarify note on info actions
ec747b3 
- Correction to the french version related to PR #834
- CIP-1694 | Reword note on info actions #834
- Complete audit of the French version
- Modification and preservation of terms that are machine readable. ex: Yes, No, Abstain
- Correction of erroneous and confusing term such as "mesure de gouvernance" and "mise"
- Fixed several turns of phrase in better French.
@Hornan7
Copy link
Contributor Author

Hornan7 commented Jun 25, 2024 •
edited
Loading

During the audit of the French version I noticed some small updates which in my opinion would be important to make to the english version in order to avoid possible (additional) confusion within the community. Can I report them to you here, or would it be better to create an Issue? or another pull request to make these fixes?

@rphair
Copy link
Collaborator

rphair commented Jun 25, 2024

small updates which in my opinion would be important to make to the english version in order to avoid possible (additional) confusion within the community. Can I report them to you here, or would it be better to create an Issue? or another pull request

@Hornan7 I think it would be better to put in a pull request ASAP since as you have noted from #800 @WhatisRT @lehins are finalising this document in anticipation of the governance launch, so it would be better to get their & community attention immediately on any remaining possible problems.

rphair
rphair approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The audit in addition to #834 looks comprehensive: I can tell these kinds of changes are for reading fluency for native speakers as well as canonical Cardano & blockchain terminology in French. Thanks again 🎉

@rphair rphair requested a review from Crypto2099 June 25, 2024 10:22
@rphair rphair added the Translation Creation or updates of non-English CIP versions. label Jun 25, 2024
@WhatisRT
Copy link
Contributor

Yes, a PR would be very welcome!

@Hornan7
Copy link
Contributor Author

Hornan7 commented Jun 25, 2024

Alright, I will have it ready today. 😃👍

@Hornan7
Copy link
Contributor Author

Hornan7 commented Jun 25, 2024

I will close this pull request for now to prioritize the one for the original file. If accepted, I will then proceed to make the necessary modifications to the French version

@Hornan7 Hornan7 closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphair rphair rphair approved these changes

@Crypto2099 Crypto2099 Awaiting requested review from Crypto2099

Assignees
No one assigned
Labels
Translation Creation or updates of non-English CIP versions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hornan7 @rphair @WhatisRT