Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if stdout at EOF before read #322

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Check if stdout at EOF before read #322

merged 1 commit into from
Apr 9, 2024

Conversation

forrejam
Copy link
Contributor

@forrejam forrejam commented Apr 9, 2024

fixes #321

@carlmontanari
Copy link
Owner

Awesome!! Will check tomorrow or later this week and get it merged. Don’t worry about the test failing, known issue with pyfakefs - I gotta pin that back to previous release for the short term.

thanks so much for all the work on this @forrejam !!

@carlmontanari
Copy link
Owner

resolves #321

@carlmontanari carlmontanari merged commit e0334ad into carlmontanari:main Apr 9, 2024
1 of 12 checks passed
@forrejam forrejam deleted the patch-1 branch April 9, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrapli hangs when connecting to misbehaving devices
2 participants
@forrejam @carlmontanari