Feature: Add corelib types #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a fully featured U256 type
This reverts commit 2a75052.
glihm
approved these changes
May 1, 2024
There was a problem hiding this comment.
Amazing @piniom. 🔥
Like this the fact that U256 exposes the bytes, we're sure that any library can just easily interact with cainome without being too opinionated.
Only the
use cainome::cairo_serde::U256;
Into the simple_get_set.rs test missing.
| }; | ||
| assert_eq!(U256::cairo_serialized_size(&u256), 2); | ||
| } | ||
| #[test] |
There was a problem hiding this comment.
Could we space the tests for easier paragraph navigation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is twofold:
NonZerotype to the cainome repo. The type will be restricted to hold integers only.fn to_bytes_be(&self) -> [u8, 32];on the type and allow it to be used with the newNonZerotype.