Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the 1.3.0 release #123

Merged
merged 39 commits into from
Aug 4, 2021
Merged

Fixes for the 1.3.0 release #123

merged 39 commits into from
Aug 4, 2021

Conversation

George-cl
Copy link
Contributor

@George-cl George-cl commented Jul 7, 2021

Summary

This includes and builds on the current develop branch (15bd0d7).

Outline of work:

Description Fixes Commit
Improvements to error handling. N/A N/A
Disables the Connect toggle if the current site is not listed in the manifest (and is therefore not integrated). Any non-integrated sites saved from previous versions will be removed for consistency. #103 1260a59
Increases the idle timeout from 30 to 60 seconds. The value is now set in the app state which will make it easier to configure by users via a Settings section in future. #111 b76c2d2
Viewing account details no longer makes the account Active #119 a2f56fe
Allows users to upload secret key files in either .cer or .pem format #91 304d301
Restricts names when renaming accounts - this is to ensure names created with the constraints can't then be edited to break the rules. #114 8aa90bc
Payment is now displayed properly in UI. Only supports StandardPayment #106 84bfa3e
I have confirmed that this is resolved with proper use of the Event Bus - tested in Signer Demo #115 N/A
Initial implementation of parsing for arbitrary deploy arguments. The support is limited but should allow clients to send a broader range of deploys and have the data displayed in the Signer. More complex args such as Tuples and Lists don't display well - this will be improved in future. #95 (Partial) 53f8696
Removes secret key field from Create Account screen. This is to prevent users manually copying the raw base64 key as a backup. Importing requires a .PEM formatted key file and we actively discourage storing keys in raw form for security reasons. N/A e298a3f
Fixes an issue where some screens would go blank when locking instead of returning to the unlock screen. (This is still a WIP issue for Create/Import screen) #112 (Partial) d047098
Persists Active Account between sessions. It will resolve errors experienced by some users when they had to unlock during the signing process. #120 4f9dbd6

Asset

Signer-v1.3.0-4f9dbd6

@George-cl George-cl marked this pull request as ready for review July 13, 2021 16:13
@cspramit
Copy link

All the fixed items tested and related issues logged in zenhub, check comments in individual PRs

Copy link

@cspramit cspramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and payment info does show in the transaction sign page now - in future we may need to revisit the Labels though

@George-cl George-cl self-assigned this Jul 28, 2021
@George-cl George-cl merged commit a546b02 into develop Aug 4, 2021
@George-cl George-cl deleted the feature/1.3-Fixes branch August 6, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signer 1.3.0 shows no account selected
4 participants