Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tqdm._tqdm.TqdmKeyError: "Unknown argument(s): {'lock_args': (False,)}" #42

Closed
MartinThoma opened this issue Jul 7, 2020 · 5 comments · Fixed by #43
Closed

tqdm._tqdm.TqdmKeyError: "Unknown argument(s): {'lock_args': (False,)}" #42

MartinThoma opened this issue Jul 7, 2020 · 5 comments · Fixed by #43
Assignees
Labels

Comments

@MartinThoma
Copy link

$ git fame --cost hour,month                                                                                                                                                  
Traceback (most recent call last):
  File "/home/math/.pyenv/versions/3.8.1/bin/git-fame", line 8, in <module>
    sys.exit(main())
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/gitfame/_gitfame.py", line 422, in main
    run(args)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/gitfame/_gitfame.py", line 370, in run
    for res in mapper(statter, gitdirs):
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/gitfame/_gitfame.py", line 231, in _get_auth_stats
    for fname in tqdm(file_list, desc=gitdir if prefix_gitdir else "Processing",
  File "/home/math/.local/lib/python3.8/site-packages/tqdm/_tqdm.py", line 855, in __init__
    raise (TqdmDeprecationWarning(dedent("""\
tqdm._tqdm.TqdmKeyError: "Unknown argument(s): {'lock_args': (False,)}"
  • Python 3.8.1
  • git-fame==1.12.1
  • tqdm==4.32.2
@MartinThoma
Copy link
Author

Works with tqdm-4.47.0

@casperdcl
Copy link
Owner

yes should have a better warning. Needs tqdm>=4.38.0.

@casperdcl casperdcl self-assigned this Jul 7, 2020
@casperdcl casperdcl added the bug label Jul 7, 2020
@MartinThoma
Copy link
Author

I would put it as a dependency in the setup.py: https://github.com/casperdcl/git-fame/blob/master/setup.py#L66

Should I create a PR?

@casperdcl
Copy link
Owner

actually it's better to go for >=4.42.0 for better concurrent multi-repo support but there are other issues with this dependency. Will fix in a few min.

casperdcl added a commit that referenced this issue Jul 7, 2020
- tqdm version bump
  + 4.44.0 for screen width detection
  + 4.42.0 for concurrent processing of multiple repos
- remove unneeded ImportError("tqdm") code
- fixes #42
@MartinThoma
Copy link
Author

Wow, you're fast! Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants