Multiple fixes for bugs around --show-email and --since=<date> #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2020 12:14
Fix for data loss when users use multiple names (as judged by string comparison) with the same email. Otherwise, the last entry iterated "wins" and all other entries get lost.
Exclude git blame entries that exist outside of the requested range (e.g. with --since=<date>). Otherwise, the user with the nearest commit to the boundary earns the LOC count. Incidentally, this also fixes a crash to stack trace when you request a date-filtered git-fame with --show-email; the auth_stats attributed the boundary lines to a (wrong) author, and that author has no commit messages in the specified range. This can be forced to trigger by requesting a git-fame since the future (e.g. --since=2024) because then one lucky owner gets attributed all of the stat; since all authors have no commits, so there's no emails to perform a lookup against whomever that lucky owner was.
|
^ travis-ci build/test succeeds. The failure is from the Deploy steps, which I have no control over. |
Hah love this. If you feel the need to refer to an unfunded OS project's sole maintainer in the plural, fine by me :D PRs always even more welcome than sponsorship. |
casperdcl
reviewed
May 11, 2020
casperdcl
requested changes
May 11, 2020
Closed
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 94.78% 94.29% -0.50%
==========================================
Files 4 4
Lines 326 333 +7
Branches 69 69
==========================================
+ Hits 309 314 +5
- Misses 11 13 +2
Partials 6 6 |
casperdcl
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello git-fame maintainers,
I have a PR for you that resolves several bugs we ran into while using this tool. Please see the commit messages for descriptions of the changes.
Known bug resolved: #31
New bug resolved: Crash to stack trace when using a selection range (e.g. --since=) and --show-email
New bug resolved: Committers that ever used more than one name (as judged by string comparison) with the same email would only have the stats earned by one of those names, causing data loss.