make noop_client private

cataggar · Jan 10, 2024 · 4fd16c4 · 4fd16c4
1 parent a5e2c39
commit 4fd16c4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/sdk/core/src/http_client/mod.rs b/sdk/core/src/http_client/mod.rs
@@ -4,7 +4,7 @@ mod noop;
 mod reqwest;
 
 #[cfg(not(any(feature = "enable_reqwest", feature = "enable_reqwest_rustls")))]
-pub use self::noop::{new_noop_client, NoopClient};
+use self::noop::new_noop_client;
 #[cfg(any(feature = "enable_reqwest", feature = "enable_reqwest_rustls"))]
 use self::reqwest::new_reqwest_client;
 use crate::error::ErrorKind;
@@ -21,7 +21,7 @@ pub fn new_http_client() -> Arc<dyn HttpClient> {
     }
     #[cfg(not(any(feature = "enable_reqwest", feature = "enable_reqwest_rustls")))]
     {
-        Arc::new(NoopClient)
+        new_noop_client()
     }
 }
 

diff --git a/sdk/core/src/http_client/noop.rs b/sdk/core/src/http_client/noop.rs
@@ -1,9 +1,9 @@
 use async_trait::async_trait;
 
 #[derive(Debug)]
-pub struct NoopClient;
+struct NoopClient;
 
-pub fn new_noop_client() -> std::sync::Arc<dyn crate::HttpClient> {
+pub(crate) fn new_noop_client() -> std::sync::Arc<dyn crate::HttpClient> {
     std::sync::Arc::new(NoopClient)
 }
 

diff --git a/sdk/core/src/lib.rs b/sdk/core/src/lib.rs
@@ -55,8 +55,6 @@ pub use error::{Error, Result};
 #[doc(inline)]
 pub use headers::Header;
 pub use http_client::{from_json, new_http_client, to_json, HttpClient};
-#[cfg(not(any(feature = "enable_reqwest", feature = "enable_reqwest_rustls")))]
-pub use http_client::{new_noop_client, NoopClient};
 pub use models::*;
 pub use options::*;
 pub use pageable::*;