Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various safety changes, bugfixes and added null type #101

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

tims-bsquare
Copy link
Contributor

Let me know @ceifa if you'd like this broken down into parts. These are the last of the changes in my private fork and I can appreciate you may not want to upstream all of them.

  • Support timing out callbacks from JS into Lua
  • Made calling functions from JS into Lua more robust. Previously there was a failure cause where if you created a thread, had that thread return a function, close the thread and attempt to call the function it would try to call the Lua function from within the context of a closed thread. All function calls from JS into Lua now use there own individual calling thread as Lua does when calling C functions and those threads are within a thread only used for functions within the Lua reference registry. This had an interesting side-effect that setInterval blocked the tests from completing because it no longer silently errored.
  • Inject null type
  • Protect against unable to allocate memory for thread creation
  • Fix thread missing parent reference in some cases

* Support timing out callbacks from JS into Lua
* Made calling functions from JS into Lua more robust.
  Previously there was a failure cause where if you created a thread, had that thread
  return a function, close the thread and attempt to call the function it would try
  to call the Lua function from within the context of a closed thread. All function
  calls from JS into Lua now use there own individual calling thread as Lua does when
  calling C functions and those threads are within a thread only used for functions
  within the Lua reference registry.
  This had an interesting side-effect that setInterval blocked the tests from completing
  because it no longer silently errored.
* Inject null type
* Protect against unable to allocate memory for thread creation
* Fix thread missing parent reference in some cases
@ceifa
Copy link
Owner

ceifa commented Dec 8, 2023

Thanks for the recent changes! @tims-bsquare @Sapu94

@ceifa ceifa merged commit 669c8c4 into ceifa:main Dec 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants