Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node API #445

Closed
wants to merge 38 commits into from
Closed

Add Node API #445

wants to merge 38 commits into from

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Feb 3, 2023

Overview

Resolves #363

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein marked this pull request as draft February 3, 2023 17:16
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

PR Preview Action v1.3.0
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-445/
on branch gh-pages at 2023-03-02 08:01 UTC

@jcstein jcstein self-assigned this Feb 3, 2023
@jcstein jcstein added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Feb 3, 2023
@jcstein jcstein added the unreleased-node Unreleased Node changes label Feb 8, 2023
@jcstein
Copy link
Member Author

jcstein commented Feb 8, 2023

do you think you can split up the prototype's files in the /pages directory? the same setup that you had in your other version maybe?

@jcstein jcstein changed the title doc: deprecation notice Add Node API Feb 9, 2023
@jcstein
Copy link
Member Author

jcstein commented Feb 23, 2023

2023-02-22.19.25.55.mp4

Close -- just need to isolate the tailwind styling to the component that is on the node-api.md page

@jcstein
Copy link
Member Author

jcstein commented Feb 24, 2023

export default function Hello() {
// useTailwindLayout();
return (
<div className={styles}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want to use tailwind inside this div, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! currently attempting to use the styles imported above in import styles from "../css/tailwind.css"

@@ -0,0 +1,5 @@
.tailwind-layout {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try adding all: unset; in here

btw I am having trouble running this repo. I do yarn start which works, but localhost:3000 hangs forever

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will try this! hmm. feels like a "did you power it on and off" question, but did you run yarn first?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya I did try that :/ its running smoothly, but not loading

@jcstein
Copy link
Member Author

jcstein commented Feb 24, 2023

it's working right for this component on this page, but still applying to rest of components across site

@jcstein
Copy link
Member Author

jcstein commented Feb 25, 2023

2023-02-24.19.01.14.mp4

@jcstein jcstein mentioned this pull request Mar 15, 2023
12 tasks
@jcstein
Copy link
Member Author

jcstein commented Mar 16, 2023

I'm closing this in order to reduce potential confusion between the 2 PRs

@jcstein jcstein closed this Mar 16, 2023
@jcstein jcstein deleted the jcs.node-api-updates branch May 5, 2023 03:12
@jcstein jcstein restored the jcs.node-api-updates branch August 1, 2023 13:06
@jcstein jcstein deleted the jcs.node-api-updates branch August 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation unreleased-node Unreleased Node changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update node api docs to include fee parameter for transaction broadcasts
4 participants