Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5329 Animation duration is not consistent across browsers #5331

Merged
merged 4 commits into from
Jan 2, 2019

Conversation

serhii-yakymuk
Copy link
Contributor

Possible solution for #5329

@serhii-yakymuk
Copy link
Contributor Author

if (animationOptions && ((typeof duration !== 'undefined' && duration !== 0) || (typeof duration === 'undefined' && animationOptions.duration !== 0))) {

I think it should be enough just to check for "falsy" values here:
if (animationOptions && (duration || animationOptions.duration)) {

So code climate won't complain about complexity, am I missing something?

@kurkle
Copy link
Member

kurkle commented Jan 1, 2019

This looks good.
Updated fiddle (with master+this PR): https://jsfiddle.net/8g3g3z3u/8/
2.7.2 (same as master considering animation): https://jsfiddle.net/8g3g3z3u/7/

@simonbrunel
Copy link
Member

Thanks @serhii-yakymuk

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants