Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radar code cleanup #5624

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Radar code cleanup #5624

merged 1 commit into from
Oct 21, 2018

Conversation

benmccann
Copy link
Contributor

@etimberg I was going to try to take a look at #5359 to try to help debug it and see why the tests were failing. I noticed that most of the changes were cleanup and not related to span gaps. I thought that splitting the PR into two would help reduce the amount of changes we'd need to inspect to understand which lines were responsible for the failing tests and make the PR easier to review.

etimberg
etimberg previously approved these changes Jul 9, 2018
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (but I'm biased on this one). I like the idea of separating out the cleanup from the other PR.

index = i % count;
p0 = points[index]._view;
p1 = mapper(p0, index, view);
d0 = isDrawable(p0);
d1 = isDrawable(p1);

if (loop && loopOffset === undefined && d0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks strange that these changes have no impact on unit tests? And shouldn't we add new tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might have been pulled over from the original PR that I opened. It could be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this file from the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants