Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build HTML via DOM manipulation (vs string manipulation) #6179

Closed
wants to merge 11 commits into from
Closed

Build HTML via DOM manipulation (vs string manipulation) #6179

wants to merge 11 commits into from

Commits on Mar 29, 2019

  1. replace HTML string array with DOM node creation for legendCallback

    @ian-pvd
    ian-pvd committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    9e0a04e View commit details
    Browse the repository at this point in the history

  2. fix: don't nest labels inside spans

    @ian-pvd
    ian-pvd committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    ae9ed57 View commit details
    Browse the repository at this point in the history

  3. replace HTML string array with DOM node creation for doughnut and pol… 

    …arArea legendCallback
    @ian-pvd
    ian-pvd committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    66e7a71 View commit details
    Browse the repository at this point in the history

  4. suggestion: use for ul element variable, instead of for previous HTML… 

    … string version
    @ian-pvd
    ian-pvd committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    2e8276f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Update documentation for generateLegend method; fix corresponding uni… 

    …t tests
    dkoo committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    610d191 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from ian-pvd/wordpress-vip-code-review-patch-tests 

    Update documentation for generateLegend method; fix corresponding unit tests
    @ian-pvd
    ian-pvd authored Apr 1, 2019
    Configuration menu
    Copy the full SHA
    62c4512 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. CR fix: Use DOM node constructors, but return HTML string for backwar… 

    …ds compatibility. Reverts test updates
    @ian-pvd
    ian-pvd committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    f6447a3 View commit details
    Browse the repository at this point in the history

  2. Update unit test expected inline style spacing.

    @ian-pvd
    ian-pvd committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    f9692c2 View commit details
    Browse the repository at this point in the history

  3. CR fixes: variable declaration, conditional and logic control formatting

    @ian-pvd
    ian-pvd committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    1a01415 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. add check for datasets values in doughnut and polar area

    @ian-pvd
    ian-pvd committed May 10, 2019
    Configuration menu
    Copy the full SHA
    4745b7d View commit details
    Browse the repository at this point in the history

  2. declare variables at the top

    @ian-pvd
    ian-pvd committed May 10, 2019
    Configuration menu
    Copy the full SHA
    59e4107 View commit details
    Browse the repository at this point in the history